Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postprocess set of fields in custom class generator #626

Merged
merged 3 commits into from
Jun 5, 2021
Merged

Fix postprocess set of fields in custom class generator #626

merged 3 commits into from
Jun 5, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 5, 2021 •
edited
Loading

Motivation

Fix #625

Also expose MCIClassGenerator in case other code wants to subclass it (e.g. in PyNWB so that pynwb.MultiContainerInterface is used instead of hdmf.MultiContainerInterface)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Jun 5, 2021 •
edited
Loading

Codecov Report

Merging #626 (8bc16d5) into dev (f983e80) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #626   +/-   ##
=======================================
  Coverage   86.13%   86.13%           
=======================================
  Files          41       41           
  Lines        8237     8238    +1     
  Branches     1775     1776    +1     
=======================================
+ Hits         7095     7096    +1     
  Misses        811      811           
  Partials      331      331
Impacted Files Coverage Δ
src/hdmf/build/__init__.py 100.00% <100.00%> (ø)
src/hdmf/build/classgenerator.py 95.37% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f983e80...8bc16d5. Read the comment docs.

@rly rly requested a review from a team June 5, 2021 00:46
@rly rly merged commit 1b084d5 into dev Jun 5, 2021
@rly rly deleted the fix/ccg branch June 5, 2021 01:02
rly added a commit that referenced this pull request Jul 6, 2021
@rly
Fix postprocess set of fields in custom class generator (#626)
c4a28c0 
* Fix postprocess set of fields in custom class generator

* Update changelog

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajtritt ajtritt ajtritt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generating extension MCI class with __nwbfields__ fails
2 participants
@rly @ajtritt